-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
589-fixRunnerExamples #654
Conversation
I cant adjust the metrics example yet. At least I do not know what the outcome of the old morph is since it uses square.
…o 589-fixRunnerExamples
They're not identical. The |
That's due to #651, right? |
No morph is using a square collector, that I dont know how to translate it. |
Can we organize the examples a bit better? The top-level directories should be descriptive of the example's use case; there should be no generic |
I estimated that the morph transformation both had errors: Additionally refrences2 used metafacture-core/metafacture-runner/src/main/dist/examples/gnd/references2/output.xml Lines 9 to 10 in 16a41b0
So the diffs of extract.xml are: whitespaces and linesbreaks a faulty delimiter and $ diff '/home/tobias/mfExmplesOld/examples/gnd/references2/extract.xml' '/home/tobias/mfExmplesOld/examples/gnd/crisscross-connections/extract.xml'
198c198
< <data source="@name" name="name"/>
---
> <data source="@name" name="name" />
213c213
< <concat delimiter="; " name="sys">
---
> <concat delimiter=" | " name="sys">
224c224
< <concat delimiter="; " name="ent">
---
> <concat delimiter=" | " name="ent">
240d239
< </entity>
241a241,265
> <data name="filter1" source="004B.a">
> <blacklist>
> <entry name="gib" />
> <entry name="gio" />
> <entry name="giw" />
> </blacklist>
> </data>
>
> <data source="[email protected]" name="filter2">
> <whitelist>
> <entry name="Ts1" />
> <entry name="Tg1" />
> </whitelist>
> </data>
>
> <choose name="filter3">
> <data source="037G.c" />
> <data source="_id">
> <constant value="ok" />
> </data>
> <postprocess>
> <equals string="ok" />
> </postprocess>
> </choose>
> </entity> output.xml is identical. In my opinion this is a redundant example. |
Okay, fine. |
Reuse all fix workflows from #654 and bring folders together as suggested by @blackwinter in #654 (comment)
Reuse all fix workflows from #654 and bring folders together as suggested by @blackwinter in #654 (comment) and in #662
This PR translates the existing workflow examples to fix and moves the old morph examples into the morph folder. See #589
I think I was able to translate all tests and adjust the workflows with regard to newer metafacture developments. The only test I was not able to translate was: metafacture-runner/src/main/dist/examples/count/metrics
Not sure if we delete one of metafacture-runner/src/main/dist/examples/gnd/crisscross-connections or metafacture-runner/src/main/dist/examples/gnd/references2 since they are identical.